Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set variable in all possible cases of minor field (uplift to 0.71.x) #3967

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Set variable in all possible cases of minor field (uplift to 0.71.x) #3967

merged 1 commit into from
Nov 11, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 11, 2019 •
edited by bsclifton
Loading

Uplift of #3961

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 11, 2019
@brave-builds brave-builds added this to the 0.71.x - Release milestone Nov 11, 2019
@mihaiplesa mihaiplesa added the CI/skip Do not run CI builds (except noplatform) label Nov 11, 2019
bsclifton
bsclifton approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit e38c8c7 into 0.71.x Nov 11, 2019
@bsclifton bsclifton deleted the pr3961_issue_6873_0.71.x branch November 11, 2019 16:36
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
@tmancey
Merge pull request brave#2232 from brave/issues/3967
c2d86c7 
Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
@tmancey
Merge pull request brave#2232 from brave/issues/3967
70b40dd 
Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @mihaiplesa @brave-browser-releases